1. Not unit testing per se, but I notice you’re throwing exceptions for business rules – I (personally) always would use exceptions for truly exceptional cases rather than possibly, and expected, business errors – these would be returned as return values (be they enums or whatever).

2. My main tip for improvement would be to make your unit tests more granular.- the unit test’s expected behaviour is for it to throw an exception of a particular type, yet your unit test has three assertions in it: -

a. The exception will be thrown.
b. CanUpdatePaymentMethod is true.
c. GetCardPaymentMethodByPaymentMethodId was never called.

What do the latter assertions have to do with the exception being thrown – nothing. So, even though it’s convenient to have them in the same test, it’s better IMHO in the long-term to make three separate tests with their own, unique assertion (even if they have the same or similar arrange/act sections).

To avoid the need for a separate logging test, why not encapsulate your throwing of exceptions with a “ThrowAndLog” method which will take in an exception (or type of exception), log it and then throw it.

I wrote a similar post on unit testing some months ago – have a look, maybe it’ll give you some ideas: http://cockneycoder.wordpress.com/2010/01/10/six-months-down-the-line-unit-testing/

Cheers

Isaac

I suspect Chirpy may be the better long term solution for us. The reasoning behind the above was primarily as a learning task.

The downside of Chirpy (if it has one) is that it has to be installed on all dev machines that wish to work with those resources – not a great problem as the benefits of that tool seem to far outweigh the negatives, and it’ll be no problem in adding tooling to the solution.

So in short, learning exercise in the first instance that is likely (longer term) to become a T4 style task rather than a build task.

thanks for actually reading! lol

I’m interested to know why you have chosen to compress resources as a part of the build process rather than a runtime solution like SquishIt (http://www.codethinked.com/squishit-the-friendly-aspnet-javascript-and-css-squisher).
Not that I think one should be a preferred solution over the other, more than it would be interesting to highlight the advantages and disadvantages over both solutions. Ultimately, however, you are using YUI compressor anyway but one is at build time and the other at runtime.

This is the first I’ve seen of Chirpy too. Haven’t had the chance to use it yet but it looks brilliant at a first glance.

http://stackoverflow.com/questions/385367/what-requests-do-browsers-f5-and-ctrl-f5-refreshes-generate

and yes.. +1 for your visitor count…